From e73e6140163233561020301407d8eb8b6b35d10d Mon Sep 17 00:00:00 2001
From: jasmine <its.jassy@pm.me>
Date: Thu, 1 May 2025 12:00:03 +0800
Subject: [PATCH] chore: refactor

---
 home-manager/sajenim/features/cli/default.nix | 10 ++++++-
 home-manager/sajenim/features/cli/mpd.nix     | 13 +++++----
 .../sajenim/features/desktop/default.nix      | 24 +++++++++++++++--
 .../features/desktop/thunar/default.nix       |  6 -----
 home-manager/sajenim/fuchsia.nix              | 27 +------------------
 home-manager/sajenim/global/default.nix       |  5 +---
 nixos/common/users/sajenim/xmonad/default.nix |  8 +++++-
 7 files changed, 48 insertions(+), 45 deletions(-)
 delete mode 100644 home-manager/sajenim/features/desktop/thunar/default.nix

diff --git a/home-manager/sajenim/features/cli/default.nix b/home-manager/sajenim/features/cli/default.nix
index 32c157e..0592bf7 100644
--- a/home-manager/sajenim/features/cli/default.nix
+++ b/home-manager/sajenim/features/cli/default.nix
@@ -1,7 +1,15 @@
-{...}: {
+{pkgs, ...}: {
   imports = [
+    ./git.nix
     ./irc.nix
     ./mpd.nix
+    ./nvim.nix
     ./remarkable.nix
+    ./ssh.nix
+    ./zsh.nix
+  ];
+
+  home.packages = with pkgs; [
+    pulsemixer
   ];
 }
diff --git a/home-manager/sajenim/features/cli/mpd.nix b/home-manager/sajenim/features/cli/mpd.nix
index 89ea00c..ebb9887 100644
--- a/home-manager/sajenim/features/cli/mpd.nix
+++ b/home-manager/sajenim/features/cli/mpd.nix
@@ -1,4 +1,12 @@
 {pkgs, ...}: {
+
+  # Install some applications for managing mpd 
+  home.packages = with pkgs; [
+    mpc-cli
+    ncmpcpp
+  ];
+
+  # Setup our mpd client service
   services.mpd = {
     enable = true;
     musicDirectory = "nfs://viridian.home.arpa/srv/multimedia/library/music";
@@ -17,9 +25,4 @@
       }
     '';
   };
-
-  services.mpd-discord-rpc = {
-    enable = true;
-    package = pkgs.unstable.mpd-discord-rpc;
-  };
 }
diff --git a/home-manager/sajenim/features/desktop/default.nix b/home-manager/sajenim/features/desktop/default.nix
index cd635e0..ae4a172 100644
--- a/home-manager/sajenim/features/desktop/default.nix
+++ b/home-manager/sajenim/features/desktop/default.nix
@@ -1,14 +1,24 @@
-{inputs, ...}: {
+{
+  inputs,
+  pkgs,
+  ...
+}: {
   imports = [
     ./cava
     ./dunst
     ./mpv
     ./picom
     ./rofi
-    ./thunar
     ./wezterm
   ];
 
+  # Install some packages for our desktop environment
+  home.packages = with pkgs; [
+    firefox
+    gimp
+    piper
+  ];
+
   home.file = {
     # Install patched fonts
     ".local/share/fonts" = {
@@ -20,4 +30,14 @@
     # Configure the initialization of xinit
     ".xinitrc".source = ./xinitrc;
   };
+
+  # Configure GTK 2/3 applications to use gruvbox-material
+  gtk = {
+    enable = true;
+    theme = {
+      name = "Gruvbox-Material-Dark";
+      package = pkgs.unstable.gruvbox-material-gtk-theme;
+    };
+    iconTheme.name = "Gruvbox-Material-Dark";
+  };
 }
diff --git a/home-manager/sajenim/features/desktop/thunar/default.nix b/home-manager/sajenim/features/desktop/thunar/default.nix
deleted file mode 100644
index 81d7102..0000000
--- a/home-manager/sajenim/features/desktop/thunar/default.nix
+++ /dev/null
@@ -1,6 +0,0 @@
-{pkgs, ...}: {
-  home.packages = with pkgs; [
-    xfce.thunar
-    xfce.ristretto
-  ];
-}
diff --git a/home-manager/sajenim/fuchsia.nix b/home-manager/sajenim/fuchsia.nix
index e27277f..fd84f49 100644
--- a/home-manager/sajenim/fuchsia.nix
+++ b/home-manager/sajenim/fuchsia.nix
@@ -1,34 +1,9 @@
-{pkgs, ...}: {
+{...}: {
   imports = [
     ./global
-    ./features/cli
     ./features/desktop
     ./features/games
     ./features/printing
     ./features/university
   ];
-
-  # Packages for our user environment
-  home.packages = with pkgs; [
-    # Graphics
-    gimp
-    # Hardware
-    piper
-    pulsemixer
-    # Multimedia
-    mpc-cli
-    ncmpcpp
-    # Browsers
-    firefox
-  ];
-
-  # Configure GTK 2/3 applications to use gruvbox-material
-  gtk = {
-    enable = true;
-    theme = {
-      name = "Gruvbox-Material-Dark";
-      package = pkgs.unstable.gruvbox-material-gtk-theme;
-    };
-    iconTheme.name = "Gruvbox-Material-Dark";
-  };
 }
diff --git a/home-manager/sajenim/global/default.nix b/home-manager/sajenim/global/default.nix
index 164d447..61e1725 100644
--- a/home-manager/sajenim/global/default.nix
+++ b/home-manager/sajenim/global/default.nix
@@ -1,9 +1,6 @@
 {outputs, ...}: {
   imports = [
-    ../features/cli/git.nix
-    ../features/cli/ssh.nix
-    ../features/cli/nvim.nix
-    ../features/cli/zsh.nix
+    ../features/cli
   ];
 
   nixpkgs = {
diff --git a/nixos/common/users/sajenim/xmonad/default.nix b/nixos/common/users/sajenim/xmonad/default.nix
index 0a1e8f2..3230320 100644
--- a/nixos/common/users/sajenim/xmonad/default.nix
+++ b/nixos/common/users/sajenim/xmonad/default.nix
@@ -3,17 +3,23 @@
   inputs,
   ...
 }: {
+  # Unfortunately some of these cannot be managed by
+  # home-manager, so we must install them to the system.
+
   environment = {
     systemPackages = [
       # Required for some XFCE/GTK stuff
       pkgs.dconf
+      # Picture viewer
+      pkgs.xfce.ristretto
       # Install our XMonad and Xmobar configuration
       inputs.xmonad-config.packages.${pkgs.system}.default
     ];
   };
 
-  # Required dependencies for our xfce/gtk programs
   programs = {
+    # File browser
+    thunar.enable = true;
     # Configuration storage system for xfce
     xfconf.enable = true;
   };